Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to generate a beforeInput event for buggy composition scenarios in IE #7926

Closed
wants to merge 1 commit into from

Conversation

robbertbrak
Copy link

This PR attempts to fix facebookarchive/draft-js#695.

The Sogou Wubi Chinese IME does not always produce composition or input events in IE, particularly when typing full-width punctuation in a contentEditable div. I tried to work around this by marking the keyDown event that initiates the 'pseudo-composition' and handling the corresponding keyUp if it is not handled in the normal manner.

@facebook-github-bot
Copy link

Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email cla@fb.com with your details so we can update your status.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Oct 4, 2017

Sorry your PR was never addressed. I'm compiling a list of issues and unreviewed PRs in #11097 and we'll take a look at yours as soon as we can.

@robbertbrak
Copy link
Author

Thanks @gaearon! As this was a while ago, it's worth checking whether this is still an issue with newer versions of Sogou Wubi.

@robbertbrak
Copy link
Author

@gaearon: I just checked it again with a fresh install of Sogou Wubi. Unfortunately the issue is still present.

@gaearon
Copy link
Collaborator

gaearon commented Nov 21, 2017

Which versions of IE is this relevant for?

@gaearon
Copy link
Collaborator

gaearon commented Jan 3, 2018

Does this only happen for IE11, or is this relevant for Edge users as well?

@gaearon
Copy link
Collaborator

gaearon commented Jan 5, 2018

I'm going to close because there's not enough information for me to make a decision. If this only affects IE11 I don't think we'll be fixing this. If it affects Edge as well, we can reconsider.

@gaearon gaearon closed this Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chinese punctuation added with Sogou Wubi disappears in Win7/IE11
4 participants