Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor precacheChildNodes slightly #8018

Merged
merged 1 commit into from
Nov 10, 2016
Merged

Refactor precacheChildNodes slightly #8018

merged 1 commit into from
Nov 10, 2016

Conversation

eoin
Copy link
Contributor

@eoin eoin commented Oct 19, 2016

This ‘fixes’ a bizarre IE9 script engine issue, discussed in #7803 (comment).

@facebook-github-bot
Copy link

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@aweary
Copy link
Contributor

aweary commented Oct 19, 2016

@ccoffey can you confirm this fix resolves your issue?

@eoin
Copy link
Contributor Author

eoin commented Oct 19, 2016

@aweary yep! I work with @ccoffey 😄, and we've verified that this resolves the issue, with our app, and with the repro-case.

@ccoffey
Copy link

ccoffey commented Oct 19, 2016

@aweary confirmed, this does resolve the issue I created!

@aweary
Copy link
Contributor

aweary commented Nov 5, 2016

@spicyj @sebmarkbage does this change seem OK to you?

@sophiebits
Copy link
Collaborator

Sure, I guess. No guarantee it won't break again later.

@aweary
Copy link
Contributor

aweary commented Nov 5, 2016

Yeah, I'm not big on including a fix without knowing exactly why its a fix. But I suppose its a harmless change.

@eoin can you resolve the merge conflicts?

@eoin eoin closed this Nov 6, 2016
This ‘fixes’ a bizarre IE9 script engine issue. #7803
@eoin eoin reopened this Nov 6, 2016
@eoin
Copy link
Contributor Author

eoin commented Nov 6, 2016

@aweary resolved.

@gaearon gaearon self-assigned this Nov 8, 2016
@gaearon gaearon added this to the 15-next milestone Nov 10, 2016
@gaearon gaearon merged commit 6ce8f1f into facebook:master Nov 10, 2016
@gaearon
Copy link
Collaborator

gaearon commented Nov 10, 2016

LGTM, thanks.

@steroberts89
Copy link

Does anyone have an date for the version which contains this release?

@gaearon
Copy link
Collaborator

gaearon commented Dec 13, 2016

Ideally we'd like the next patch release to also fix #8392. So if you could help find a solution to it, we could get it out quicker.

@gaearon gaearon modified the milestones: 15-hipri, 15-lopri, 15.4.2 Jan 6, 2017
gaearon pushed a commit that referenced this pull request Jan 6, 2017
This ‘fixes’ a bizarre IE9 script engine issue. #7803
(cherry picked from commit 6ce8f1f)
@gaearon
Copy link
Collaborator

gaearon commented Jan 6, 2017

This is now out in 15.4.2.
Please verify.

acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
This ‘fixes’ a bizarre IE9 script engine issue. facebook#7803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants