add dependencies to react-test-renderer and react-addons #8467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What** and **Why**: * When using npm version 2, `object-assign` and `fbjs` were not getting properly installed * This PR adds `object-assign` and `fbjs` as explicit dependencies to both `react-test-renderer` and `react-addons`
|
Does |
montusardar1234
approved these changes
Nov 30, 2016
|
Can you show me what is test renderer using from |
|
|
Oh right, it ships with a complete renderer copy now.. |
|
LGTM |
|
react-test-renderer v15.4.1 is the latest and does not include this fix. How is it planned to be released? |
|
It will be released as part of 15.4.2 (shortly). |
gaearon
pushed a commit
that referenced
this pull request
Jan 6, 2017
**What** and **Why**: * When using npm version 2, `object-assign` and `fbjs` were not getting properly installed * This PR adds `object-assign` and `fbjs` as explicit dependencies to both `react-test-renderer` and `react-addons` (cherry picked from commit 7cd2602)
|
Should be fixed if you update all packages to 15.4.2. |
richardgiddings
pushed a commit
to richardgiddings/menu
that referenced
this pull request
Jan 9, 2017
…cting testing.
richardgiddings
pushed a commit
to richardgiddings/menu
that referenced
this pull request
Jan 9, 2017
…cting testing.
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
**What** and **Why**: * When using npm version 2, `object-assign` and `fbjs` were not getting properly installed * This PR adds `object-assign` and `fbjs` as explicit dependencies to both `react-test-renderer` and `react-addons`
1 task
laurinenas
pushed a commit
to laurinenas/react
that referenced
this pull request
May 28, 2018
**What** and **Why**: * When using npm version 2, `object-assign` and `fbjs` were not getting properly installed * This PR adds `object-assign` and `fbjs` as explicit dependencies to both `react-test-renderer` and `react-addons`
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
**What** and **Why**: * When using npm version 2, `object-assign` and `fbjs` were not getting properly installed * This PR adds `object-assign` and `fbjs` as explicit dependencies to both `react-test-renderer` and `react-addons`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and Why:
object-assignandfbjswere not installedobject-assignandfbjsas explicit dependencies to bothreact-test-rendererandreact-addons