Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test renderer unmount #8512

Merged
merged 3 commits into from
Dec 14, 2016
Merged

Conversation

gre
Copy link
Contributor

@gre gre commented Dec 7, 2016

Fixes #8459

gre added a commit to gre/gl-react that referenced this pull request Dec 7, 2016
this is a workaround for tests to pass, as soon as React have this fixed facebook/react#8512
gre added a commit to gre/gl-react that referenced this pull request Dec 7, 2016
this is a workaround for tests to pass ( stackgl/headless-gl#90 ), as soon as React have this fixed facebook/react#8512
@aweary aweary self-assigned this Dec 9, 2016
Copy link
Contributor

@aweary aweary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @gre! LGTM

@aweary
Copy link
Contributor

aweary commented Dec 9, 2016

@gre can you run the scripts/fiber/record-test script and add the results to this please? I think we can merge afterwards

@gre
Copy link
Contributor Author

gre commented Dec 9, 2016

done

@aweary aweary merged commit 931cad5 into facebook:master Dec 14, 2016
@aweary
Copy link
Contributor

aweary commented Dec 14, 2016

Thanks again @gre!

@gaearon
Copy link
Collaborator

gaearon commented Feb 6, 2017

@aweary

Please always set the "next" (non-specific) milestone when merging. Otherwise the release tool won't see the pull request and we'll keep skipping it until the next major.

@gaearon gaearon added this to the 15-hipri milestone Feb 6, 2017
bvaughn pushed a commit that referenced this pull request Mar 29, 2017
* [react-test-renderer] unmount the inner instances

Fixes #8459

* add a test for #8459

* add new test in tests-passing.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants