Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AMD and Brunch issues #8686

Merged
merged 5 commits into from
Jan 5, 2017
Merged

Fix AMD and Brunch issues #8686

merged 5 commits into from
Jan 5, 2017

Commits on Jan 5, 2017

  1. Add manual build fixtures

    @gaearon
    gaearon committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    cebff96 View commit details
    Browse the repository at this point in the history

  2. Inject ReactDOM into ReactWithAddons from ReactWithAddons 

    We used to read ReactDOM as a global inside ReactAddonsDOMDependenciesUMDShim.
This didn't work in AMD environments such as RequireJS and SystemJS.

Instead, I changed it so that ReactDOM gets injected into ReactWithAddons by ReactDOM itself.
This way we don't have to try to require it (which wouldn't work because AMD doesn't handle circular dependencies well).

This means you have to load ReactDOM first before using ReactDOM-dependent addons, but this was already the case before.

This commit makes all build fixtures pass.
    @gaearon
    gaearon committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    db5b7ab View commit details
    Browse the repository at this point in the history

  3. Memoize ReactDOM to avoid going into require on every access

    @gaearon
    gaearon committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    3302174 View commit details
    Browse the repository at this point in the history

  4. Add Brunch fixture

    @gaearon
    gaearon committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    fe8d64e View commit details
    Browse the repository at this point in the history

  5. Inline requires to work around Brunch bug 

    See facebook#8556 and brunch/brunch#1591 (comment) for context.
This appears to be a Brunch bug but we can keep a temporary fix until the next major.
    @gaearon
    gaearon committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    593c70e View commit details
    Browse the repository at this point in the history