Added double newline delimiters to dynamically-populated warnings #8754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll review after you find the others: #8719 (comment). |
|
@richiethomas Is this ready for review? |
|
@gaearon yes, just pushed the last of the newlines yesterday. |
gaearon
requested changes
Jan 13, 2017
| @@ -44,7 +44,7 @@ var ReactNativeTagHandles = { | |||
| assertRootTag: function(tag: number): void { | |||
| invariant( | |||
| this.reactTagIsNativeTopRootID(tag), | |||
| 'Expect a native root tag, instead got %s', tag | |||
| '\n\nExpect a native root tag, instead got %s', tag | |||
There was a problem hiding this comment.
This doesn't look right to me. It puts a newline before the whole message, not before the addendum.
(There is no addendum here.)
Also, I would prefer if we avoided modifying invariant messages. Let’s stick to warnings for now.
* 'beginLifeCycleTimer' function of ReactDebugTool.js
* 'findDOMNode' function of findDOMNode.js
* 'bindAutoBindMethod' function of ReactClass.js
* 'warnNoop' function of ReactServerUpdateQueue.js
* 'getInternalInstanceReadyForUpdate' function of ReactUpdateQueue.js
* 'warnNoop' function of ReactNoopUpdateQueue.js
* 'getDeclarationErrorAddendum' function of ReactDOMComponent.js
* 'getSourceInfoErrorAddendum' function of ReactElementValidator.js
* 'getDeclarationErrorAddendum' function of instantiateReactComponent.js and ReactElementValidator.js
* 'traverseAllChildrenImpl' function of traverseAllChildren.js
* 'attachRef' function of ReactRef.js
* 'mountIndeterminateComponent' function of ReactFiberBeginWork.js
* 'createFiberFromElementType' function of ReactFiber.js
* 'getDeclarationErrorAddendum' function of ReactDOMSelect.js
* 'unmountComponentAtNode' function of ReactMount.js
* 'getDeclarationErrorAddendum' function of ReactControlledValuePropTypes.js
* 'checkRenderMessage' function of CSSPropertyOperations.js
* 'getDeclarationErrorAddendum' function of ReactDomFiberSelect.js
* 'getCurrentComponentErrorInfo' function in 'ReactElementValidator'
* 'getDeclarationErrorAddendum' function in ReactDOMFiberComponent.js
|
You don't need to close the PR—can just push a new commit on top. |
|
Right, sorry I keep forgetting. :) This PR removes the delimiters from all calls to 'invariant'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8719
Before submitting a pull request, please make sure the following is done...
master.npm test).npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.