Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closure Compiler wrong assignment order in instantiateReactComponent #8895

Merged
merged 1 commit into from
Feb 6, 2017
Merged

Closure Compiler wrong assignment order in instantiateReactComponent #8895

merged 1 commit into from
Feb 6, 2017

Conversation

anmonteiro
Copy link
Contributor

@anmonteiro anmonteiro commented Jan 30, 2017

This fixes #8894

@anmonteiro
Copy link
Contributor Author

Can we get this reviewed? This simple change alone can go a long way empowering Google Closure Compiler users to get dead-code elimination on React by consuming it from a node_modules installation.

@anmonteiro anmonteiro changed the title Change the order between function declaration and object assignment Closure Compiler wrong assignment order in instantiateReactComponent Feb 5, 2017
@gaearon gaearon added this to the 15-hipri milestone Feb 6, 2017
@gaearon gaearon merged commit 4313059 into facebook:master Feb 6, 2017
@gaearon
Copy link
Collaborator

gaearon commented Feb 6, 2017

This looks fine by itself. However, just to set expectations, I’m not quite sure when we’ll cut another patch release, and React 16 will contain a completely rewritten core, so this change won’t affect it.

@anmonteiro anmonteiro deleted the react-8894 branch February 6, 2017 16:36
@anmonteiro
Copy link
Contributor Author

Thanks!

I understand. So to avoid encountering similar problems with Fiber, are there instructions to build master locally and take it for a spin?

@gaearon
Copy link
Collaborator

gaearon commented Feb 6, 2017

@anmonteiro

Yea. You should be able to build from master and then import react-dom/fiber instead of react-dom.

@anmonteiro
Copy link
Contributor Author

Great. Will do and report any issues I encounter along the way.

@anmonteiro
Copy link
Contributor Author

@gaearon Don't know where else to provide feedback, but everything seems to work successfully when consuming ReactDOMFiber with the Google Closure Compiler 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closure Compiler: wrong assignment order in instantiateReactComponent
3 participants