Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where null props is passed to constructor when resuming mount #9576

Merged
merged 3 commits into from
May 1, 2017
Merged

Fix bug where null props is passed to constructor when resuming mount #9576

merged 3 commits into from
May 1, 2017

Commits on May 1, 2017

  1. Demonstrate failing test when resuming mount of class component

    @acdlite
    acdlite committed May 1, 2017
    Configuration menu
    Copy the full SHA
    ae4fa9a View commit details
    Browse the repository at this point in the history

  2. Fix bug where null props is passed to constructor when resuming mount 

    Another example of where the pending/progressed/memoized props model
would benefit from a refactor.
    @acdlite
    acdlite committed May 1, 2017
    Configuration menu
    Copy the full SHA
    9145f40 View commit details
    Browse the repository at this point in the history

  3. Only perform class checks on initial mount 

    Avoids firing warnings multiple times
    @acdlite
    acdlite committed May 1, 2017
    1 Configuration menu
    Copy the full SHA
    4d81744 View commit details
    Browse the repository at this point in the history