Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Safari fix for input changes #9960

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Jun 14, 2017

fixes #9956

@gaearon
Copy link
Collaborator

gaearon commented Jun 14, 2017

Can you verify this works on Safari?

@jquense
Copy link
Contributor Author

jquense commented Jun 14, 2017

I can't right this moment, I yanked this straight from master (#6648) so presumably FB would be broken still if it didn't? :P

@gaearon
Copy link
Collaborator

gaearon commented Jun 14, 2017

That's my thinking too. 😄 Let's get in. Thanks.

@gaearon
Copy link
Collaborator

gaearon commented Jun 14, 2017

(I'll still wait for CI)

@gaearon
Copy link
Collaborator

gaearon commented Jun 14, 2017

Eh, seems like I broke CI with lint 😞

This is okay to merge:

Received return code 1 from: ./node_modules/.bin/gulp lint
Received return code 0 from: node ./scripts/prettier/index
Received return code 0 from: ./node_modules/.bin/gulp flow
Received return code 0 from: ./node_modules/.bin/grunt build
Received return code 0 from: ./scripts/circleci/test_extract_errors.sh
Received return code 0 from: ./scripts/circleci/track_stats.sh
Received return code 0 from: node ./addons/test

@blling
Copy link

blling commented Mar 4, 2018

Some brower do not support hasOwnProperty on DOM node, need check node.hasOwnProperty if it is defined first here :(

@nhunzaker
Copy link
Contributor

@blling Yikes! Do you know in which browsers this is the case?

@blling
Copy link

blling commented Mar 5, 2018

I found IE8 for now... I know React has dropped support of IE8~~, but if you could use Object.hasOwnProperty.call() is a better way.

@blling
Copy link

blling commented Mar 6, 2018

@nhunzaker do you think the issue of hasOwnProperty should be fix in React15.6.x?

@jquense
Copy link
Contributor Author

jquense commented Mar 6, 2018

I don't think so, we are actively removing ie8 specific code. I don't think it makes sense to cover that case just here

@nhunzaker
Copy link
Contributor

Yeah; that's where I'm at too.

@blling
Copy link

blling commented Mar 6, 2018

o_o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants