network activity callbacks from DefaultNetworkLayer

[bmcmahen]

I'm developing a react-native app using relay and would find network activity callbacks useful from the DefaultNetworkLayer. It would allow me to centralize management of the StatusBarIOS network activity indicator if I could tell when a) an active request has started, and b) the request has ended (either successfully, or with an error).

I think I could do a PR for this relatively easily, if there's interest. The alternatives to this approach would be to use the readyState in Relay.Renderer or to build my own custom network layer. The problem with the first approach is that, especially in mobile apps, you end up with Relay.Renderer calls throughout the app, and sometimes the readyState doesn't indicate whether the data is being fetched from the cache, or over the network layer.

[josephsavona]

In general we'd prefer to keep the default network layer as simple as possible. To add custom functionality such as network activity callbacks, you can compose the default implementation in your own object/class with whatever hooks you need. Does this work for your use case?

[bmcmahen]

Makes sense. I'll give composing the default implementation a try. Thanks.

[KyleAMathews]

@ben you might be interested in this recent effort
https://github.com/nodkz/react-relay-network-layer

On Thu, May 5, 2016 at 6:15 PM Ben McMahen notifications@github.com wrote:

Closed #1120 #1120.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1120 (comment)

[bmcmahen]

For what it's worth, composing the default implementation was super easy and proved perfect for the task.

[KyleAMathews]

Cool! Big props to @nodkz for taking this on.