relay-compiler v13: Linux-ARM platform support

[atatarenko]

Hello relay team! Thank you for all the effort you've been putting into the relay!

I have a question (or even a feature request) but let me quickly describe the context.

My laptop is on based apple m1 platform, at the same my team and I prefer to develop in docker containers.
It means that my usual platform is linux-arm64 which is not supported among other platforms listed below:

relay/packages/relay-compiler/index.js

Lines 16 to 26 in 427c01b

	if (process.platform === 'darwin' && process.arch === 'x64') {
	binary = path.join(__dirname, 'macos-x64', 'relay');
	} else if (process.platform === 'darwin' && process.arch === 'arm64') {
	binary = path.join(__dirname, 'macos-arm64', 'relay');
	} else if (process.platform === 'linux' && process.arch === 'x64') {
	binary = path.join(__dirname, 'linux-x64', 'relay');
	} else if (process.platform === 'win32' && process.arch === 'x64') {
	binary = path.join(__dirname, 'win-x64', 'relay.exe');
	} else {
	binary = null;
	}

Now I have to run the new relay-compiler in a docker container forcing the platform for it this way platform: linux/x86_64 which doesn't bring any benefits of node -> rust migration when it comes to speed. And actually brings another layer of virtualization to the whole app. Not that bad but not perfect too.

Do you have any plans regarding linux-arm64 support for the new compiler?

[alunyov]

Thanks for suggestion, I think we could add support for this here:

relay/.github/workflows/ci.yml

Lines 83 to 101 in 427c01b

	target:
	- target: x86_64-unknown-linux-musl
	os: ubuntu-latest
	build-name: relay
	artifact-name: relay-compiler-linux-x64
	packages: musl-tools
	features: vendored
	- target: x86_64-apple-darwin
	os: macos-latest
	build-name: relay
	artifact-name: relay-compiler-macos-x64
	- target: aarch64-apple-darwin
	os: macos-latest
	build-name: relay
	artifact-name: relay-compiler-macos-arm64
	- target: x86_64-pc-windows-msvc
	os: windows-latest
	build-name: relay.exe
	artifact-name: relay-compiler-win-x64

The downsides:

• it will decrease the CI time (probably fine)
• it will increase the npm package size, as we're uploading all artifacts for all platforms there.

There is a PR to add platform-specific compilers as optional dependencies, but this approach also has downsides (as optional dependencies may be disabled in some cases).

I suggest keeping this issue open for now, if more people will want this, we can add support for this.

[ro-savage]

@alunyov - This is certainly very important - every new macbook is going to be arm-based. Given a large percentage of developers use macs - this issue is only going to increase.

As our organisation about 80% of developers are now on M1 Macbooks and would be unable to do builds using Relay v13.

[wasd171]

@alunyov you have added a "help wanted" label. How exactly could the community help? This issue is slowing down our development, I'd be willing to invest my time to fix it

[alunyov]

@wasd171 something similar to this PR: #3667 - where we need to update CI to include a new target, also update the JS part of the compiler to resolve the correct binary.

[wasd171]

@alunyov I have created a PR #3882 that addresses this issue

[TrySound]

Does it mean relay-compiler package size will be ~10-20MB bigger?

[wasd171]

@TrySound additional binary is ~5 MB

[bencoveneyttl]

Looks like the fix was shipped in https://github.com/facebook/relay/releases/tag/v14.0.0 and this can be closed.