Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Relay.QueryConfig as a public method #1279

Closed
wants to merge 1 commit into from

Conversation

washt
Copy link
Contributor

@washt washt commented Jul 12, 2016

@steveluscher should we go ahead and depreciate RelayRoute here too?

@ghost ghost added the CLA Signed label Jul 12, 2016
@wincent
Copy link
Contributor

wincent commented Jul 18, 2016

Thanks for the PR @washt. Just trying to understand the intent here. Do you have some context that you can link to here for why you want to do this? RelayQueryConfig itself doesn't really do anything at all, so I am not sure of the value of exposing it. The rest of Relay really only cares about the interface, RelayQueryConfigInterface.

@wincent
Copy link
Contributor

wincent commented Jul 18, 2016

...aaaand I found it (here).

@ghost ghost added the CLA Signed label Jul 18, 2016
@josephsavona
Copy link
Contributor

@facebook-github-bot shipit

@ghost
Copy link

ghost commented Aug 4, 2016

Thanks for importing.If you are an FB employee go to Phabricator to review internal test results.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants