Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a trailing comma in the gulp file which breaks older node builds #2318

Closed
wants to merge 1 commit into from

Conversation

orta
Copy link
Contributor

@orta orta commented Feb 9, 2018

See comments in #2317 (comment)

@orta orta changed the title Remove a trailing comma in the gulp file which breaks old node builds Remove a trailing comma in the gulp file which breaks older node builds Feb 9, 2018
@orta orta force-pushed the patch-2 branch 6 times, most recently from 96f1be6 to bab76c5 Compare February 10, 2018 13:28
@orta
Copy link
Contributor Author

orta commented Feb 10, 2018

OK, the scope of this PR changed a bit.

I've added a .prettierignore file, which tells everyone's editors/prettier to ignore the JS files in scripts, then I ran yarn prettier --write "scripts/**/*" --trailing-comma es5 over the files so that they'll run on older node runtimes.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstejada has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants