Set inFlight to true before calling commitMutationFn #3839
Conversation
In environments with local resolvers (i.e. during tests), setMutationInFlight can lose a race to a commitMutationFn callback, causing inFlight to be stuck on true. Setting isMutationInFlight to true before calling commitMutationFn prevents this.
|
Hi @tinleym! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thanks for the pull request! Could you please share an example of the issue? Or better yet, add a test case illustrating the issue that fails without this fix and validates this fix. |
|
Sure! I encountered this in Storybook, would it be OK to link a repo w/ all that overhead included? |
|
While something is better than nothing... providing a repro test case along with the fix makes it easier for me to merge your pull request. Not having that creates more work for me 😛 I took a stab at putting together a test case while procrastinating on something else this morning. It ended up being pretty straightforward: #3841 |
Summary: Basically facebook#3839 but with a repro test case that fails without the fix and passes with it Pull Request resolved: facebook#3841 Test Plan: Added a race condition repro test case that fails without the change and passes with it Reviewed By: rbalicki2 Differential Revision: D34959589 Pulled By: voideanvalue fbshipit-source-id: 0f98ac2067470ab7ba0cef02e5b7941397f28407
|
merged with eb0fc26. thanks for reporting the issue and providing a fix! |
In environments with local resolvers (i.e. during tests), setMutationInFlight can lose a race to a commitMutationFn callback, causing inFlight to be stuck on true. Setting isMutationInFlight to true before calling commitMutationFn prevents this.