Ignore BOM when lexing #3908
Ignore BOM when lexing #3908
Conversation
|
Hi @tobias-tengler! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Rather than a snapshot test (where the BOM is very easy to overlook) could we create a unit test that uses an explicit escaped string? |
Done :) |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
If a GraphQL schema file should be encoded as
UTF-8 with BOM, the lexer will skip the BOM (\ufeff) character.I've also added a regression snapshot test.
Closes #3798