Fix minor issue in the new relay docs #428
Conversation
|
Looks reasonable to me. Thanks for the PR! @facebook-github-bot shipit |
| @@ -7,7 +7,7 @@ permalink: docs/thinking-in-relay.html | |||
| next: videos | |||
| --- | |||
|
|
|||
| Relay's approach to data-fetching is heavily inspired by our experience with React. In particular, React breaks complex interfaces into reusable **components**, allowing developers to reason about discrete units of an application in isolation, and reducing the coupling between disparate parts of an application. Even more important is that these components are **declarative**: they allow developers to specify *what* the UI should like look for a given state, and not have to worry about *how* to show that UI. Unlike previous approaches that used imperative commands to manipulate native views (e.g. the DOM), React uses a UI description to automatically determine the necessary commands. | |||
| Relay's approach to data-fetching is heavily inspired by our experience with React. In particular, React breaks complex interfaces into reusable **components**, allowing developers to reason about discrete units of an application in isolation, and reducing the coupling between disparate parts of an application. Even more important is that these components are **declarative**: they allow developers to specify *what* the UI should look like for a given state, and not have to worry about *how* to show that UI. Unlike previous approaches that used imperative commands to manipulate native views (e.g. the DOM), React uses a UI description to automatically determine the necessary commands. | |||
There was a problem hiding this comment.
... the UI should like look for a given state ...
... the UI should look like for a given state ...
There was a problem hiding this comment.
You can also click the icon for displaying a "rich diff" which gives word-level diffs.
There was a problem hiding this comment.
Yes, that's it. Sorry, forgot to mention that change.
There was a problem hiding this comment.
sorry, I'm a github noob.
There was a problem hiding this comment.
Oh man, I too feel like a n00b. I literally bisected that paragraph by using copy+find+paste, lol.
There was a problem hiding this comment.
I didn't know about the "rich diff" button, so my clumsy method for inspecting this kind of thing is to git hub get 428 (via this script) to get the PR locally, and then you can do whatever you need, like git show --word-diff=color (to show word-level diffs) or git show -b (to ignore whitespace changes) etc.
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1708602776021695/int_phab to review. |
ghost
closed this
in
In the Relay new docs, the query specifies a
textfield but the response hasmessageinstead. Feel free to ignore if I misunderstood anything. Thank you!