Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same field name for pagination that compiler generates #4317

Closed
wants to merge 1 commit into from

Conversation

dwwoelfel
Copy link

It looks like the compiler generates the refetchable query using the nodeInterfaceIdField as the variable name, but the runtime always uses "id" as the variable name.

This should fix usePaginationFragment for users that set a custom nodeInterfaceIdField in their schemaConfig.

@facebook-github-bot
Copy link
Contributor

Hi @dwwoelfel!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@captbaritone
Copy link
Contributor

I think this is a duplicate of #4053?

@captbaritone
Copy link
Contributor

Closing for now. Feel free to ping here if this is different than #4053.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants