Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react-router dependency. Fix #439. #441

Closed
wants to merge 1 commit into from
+1 −1
Closed

Fix react-router dependency. Fix #439. #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/todo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"react": "^0.14.0-rc",
"react-dom": "^0.14.0-rc",
"react-relay": "file:../../",
"react-router": "^1.0.0-rc1",
"react-router": "^1.0.0-rc3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should install rc3 as is (at least with a fresh install or npm update)

Edit: sorry, misread the other issue and I see that we actually need rc3 so it's a safe move to specify that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zpao Do you mean make it precisely 1.0.0-rc3?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think this is fine, I just misunderstood the reason for the change.

"react-router-relay": "^0.5.0",
"todomvc-app-css": "^2.0.1",
"todomvc-common": "^1.0.2",
Expand Down