Fix missing Relay import in examples #453
Conversation
Test Plan: For every example `npm install` and `npm start` then open it in a browser and see it render.
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/393582277519735/int_phab to review. |
Summary: 1. Fixed the licence of examples. Now it is same as define [here](https://github.com/facebook/relay/tree/master/examples/todo#license). 2. Fixed some lint errors and warnings. Ps - All npm test are passed and lint shows no major errors. Please see the diff. Npm Test <img src="https://box.everhelper.me/attachment/301722/NuD6t5ei9i0VAGxX7avOK5Ifa4bkQt12/312416-0JwJzhXkXu4ZATUS/screen.png"/> Lint test <img src="https://box.everhelper.me/attachment/301723/pGqakY01HpgeAsKPfGOtus6xDsK7NCIc/312416-AJM6V5LS06uq0P5c/screen.png"/> Closes #433 Reviewed By: @wincent Differential Revision: D2514888 fb-gh-sync-id: c9defaf7b7694ebba4a7017be07ff6ae56dbe9dd
|
Dude I removed those relay import line because it is unused var. Lint was showing that var relay is not used so I removed it. |
|
Yeah, you're supposed to import React. I guess that could be a nice lint rule, though in some cases React will be a global so you wouldn't want to warn. |
But in that case, we should use the existing ESLint mechanisms for declaring Regardless, @kassens 👍 |
|
Yep. You'll want to enable https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-uses-react.md |
Summary: This fixes a few lint issues and also uses a single `.eslintrc` to prevent duplication and divergence of lint rules. Follow up for concerns raised in #453. Closes #460 Reviewed By: @yungsters Differential Revision: D2537193 fb-gh-sync-id: 116a852c0f75bb0ea2d657f862db6c211622632d
![https://box.everhelper.me/attachment/301722/NuD6t5ei9i0VAGxX7avOK5Ifa4bkQt12/312416-0JwJzhXkXu4ZATUS/screen.png"/](https://box.everhelper.me/attachment/301722/NuD6t5ei9i0VAGxX7avOK5Ifa4bkQt12/312416-0JwJzhXkXu4ZATUS/screen.png"/){kind=link}
![https://box.everhelper.me/attachment/301723/pGqakY01HpgeAsKPfGOtus6xDsK7NCIc/312416-AJM6V5LS06uq0P5c/screen.png"/](https://box.everhelper.me/attachment/301723/pGqakY01HpgeAsKPfGOtus6xDsK7NCIc/312416-AJM6V5LS06uq0P5c/screen.png"/){kind=link}
Test Plan:
For every example
npm installandnpm startthen open it in a browser andsee it render.