Add SchemaDocument go to definition LSP support #4669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-tengler
force-pushed
the
lsp-schema-go-to-definition
branch
from
397677d
to
558ed98
Compare
tobias-tengler
force-pushed
the
lsp-schema-go-to-definition
branch
2 times, most recently
from
a09adc0
to
6c1159b
Compare
tobias-tengler
force-pushed
the
lsp-schema-go-to-definition
branch
from
6c1159b
to
e3fb89d
Compare
tobias-tengler
force-pushed
the
lsp-schema-go-to-definition
branch
from
e3fb89d
to
1e89ab0
Compare
|
@captbaritone Thanks for merging the SchemaDocument support :) This is now also ready to be merged. EDIT: Remember that you need to run the VS Code extension from source when testing. Otherwise the LSP will not be activated for |
tobias-tengler
force-pushed
the
lsp-schema-go-to-definition
branch
from
1e89ab0
to
92d9c4b
Compare
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@captbaritone merged this pull request in 68c7cca. |
drewatk
pushed a commit
to drewatk/relay
that referenced
this pull request
Jul 31, 2024
v17.0.0 * tag 'refs/tags/v17.0.0': (891 commits) v17.0.0 Cut docs version v17.0.0 bump version of vscode extension for release Update Algolia app & key (facebook#4715) Validate edgeTypeName argument points to an existing type (facebook#4621) Parallel watchman queries for saved state and changed files Update Cargo.lock (facebook#4714) Implement schema generation for weak object fields Add code action to rename fragment (facebook#4697) Add SchemaDocument go to definition LSP support (facebook#4669) Fix Rust error caught by Clippy (facebook#4713) Deploy 0.238.0 to xplat Tests for interface schema validation Attach previous location to duplicate type diagnostic Include source location in schema tests Refactor to pass Arc<Config> to watchman source instead of &Config No need to pass self.config if you have self Enforce no duplicate type names Make schema validation the default Update integration tests to have valid schemas ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds go to definition support for types and directives within a
.graphqlfile.