Skip importing export types in TS

[drewatk]

A fix for a typescript generation bug discovered from the work in #4753, with efforts to enable checking for all TS generated files #4745

This fixes a class of Typescript errors in generated typescript files with TS checking enabled:

/src/__generated__/mutation.graphql.ts(11,27): error TS2305: Module '"relay-runtime"' has no exported member 'Mutation'.
/src/__generated__/mutation.graphql.ts(11,27): error TS6133: 'Mutation' is declared but its value is never read.

The root cause is the exported type is both not exported by the TS types, and not used due to typescript using the export default syntax.
Where flow would generate the following export:

module.exports = ((node/*: any*/)/*: Mutation<
  validateMutationTest9ChangeNameIncludeMutation$variables,
  validateMutationTest9ChangeNameIncludeMutation$data,
>*/);

Typescript would generate the following, not using the Mutation type:

export default node;

This fix removes the extraneous import type when the language is set as typescript.

[facebook-github-bot]

Hi @drewatk!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[captbaritone]

Looks very sensible! Just one tiny nit

[captbaritone]

Looks good! Happy to import/merge once the CLA is signed.

[facebook-github-bot]

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[drewatk]

Can this be merged @captbaritone ?

[facebook-github-bot]

This pull request has been merged in 0f49c2e.

[captbaritone]

@drewatk Thanks for the ping. Merged. We are still working on some issues with our CI which means we are not currently cutting our @main NPM releases relay-compiler@main. Were you depending upon using those releases to validate this change at Microsoft? If so, let me know and I can try to find a way to get a release here.

[alloy]

@drewatk We should really consider adding some tests for the TS typings that get emitted.