Skip to content

Commit

Permalink
Fix comment for option periodic_compaction_seconds (#11227)
Browse files Browse the repository at this point in the history
Summary:
the comment for option `periodic_compaction_seconds` only mentions support for Leveled and FIFO compaction, while the implementation supports all compaction styles after #5970. This PR updates comment to reflect this.

Pull Request resolved: #11227

Reviewed By: ajkr

Differential Revision: D43325046

Pulled By: cbi42

fbshipit-source-id: 2364dcb5a01cd098ad52c818fe10d621445e2188
  • Loading branch information
cbi42 authored and facebook-github-bot committed Feb 21, 2023
1 parent 83bc03a commit ebfca2c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion include/rocksdb/advanced_options.h
Original file line number Diff line number Diff line change
Expand Up @@ -863,7 +863,9 @@ struct AdvancedColumnFamilyOptions {
// age is based on the file's last modified time (given by the underlying
// Env).
//
// Supported in Level and FIFO compaction.
// Supported in all compaction styles.
// In Universal compaction, rocksdb will try to do a full compaction when
// possible, see more in UniversalCompactionBuilder::PickPeriodicCompaction().
// In FIFO compaction, this option has the same meaning as TTL and whichever
// stricter will be used.
// Pre-req: max_open_file == -1.
Expand Down

0 comments on commit ebfca2c

Please sign in to comment.