Pick files from the last sorted run in size amp compaction picker #11740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cbi42
reviewed
Aug 23, 2023
| // base file (overrides configured values of file-size ratios, | ||
| // min_merge_width and max_merge_width). | ||
| // | ||
| // exceeeds the configured value, then do a compaction |
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
hx235
force-pushed
the
refactor_size_amp_picker
branch
from
ed2867c
to
54108a3
Compare
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context/Summary:
Same intention as #2693 - basically we now pick from the last sorted run and expand forward till we can't
Test:
Existing UT
Stress test
python3 tools/db_crashtest.py --simple blackbox --compaction_style=1for an hour