Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition between event listener and error handler #12803

Closed
wants to merge 1 commit into from
Closed

Fix race condition between event listener and error handler #12803

wants to merge 1 commit into from

Conversation

jowlyzhang
Copy link
Contributor

Fix a race for accessing bg_error_ after mutex is released. We make some copies before releasing to avoid this.

@facebook-github-bot
Copy link
Contributor

@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jowlyzhang jowlyzhang requested a review from cbi42 June 24, 2024 17:34
cbi42
cbi42 approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@cbi42 cbi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@jowlyzhang merged this pull request in fa4ffc8.

@jowlyzhang jowlyzhang deleted the fix_race branch June 24, 2024 21:20
jowlyzhang added a commit to jowlyzhang/rocksdb that referenced this pull request Jun 24, 2024
@jowlyzhang
Add entry for facebook#12803: fix race between event listener and err…
143edf7 
…or handler
facebook-github-bot pushed a commit that referenced this pull request Jun 25, 2024
@jowlyzhang @facebook-github-bot
Add entry for #12803: fix race between event listener and error handl…
ff204d8 
…er (#12809)

Summary:
As titled.

Pull Request resolved: #12809

Reviewed By: hx235

Differential Revision: D58974154

Pulled By: jowlyzhang

fbshipit-source-id: 7e44b54d9fa3bfbd58a4154a2c7e91aec905c34b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbi42 cbi42 cbi42 approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jowlyzhang @facebook-github-bot @cbi42