Universal Compaction with TTL #4749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar0
changed the title
|
Discarding, as this can more be better implemented via the periodic compaction framework that was laid out recently for universal. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 23, 2019
Summary: `options.ttl` is now supported in universal compaction, similar to how periodic compactions are implemented in PR #5970 . Setting `options.ttl` will simply set `options.periodic_compaction_seconds` to execute the periodic compactions code path. Discarded PR #4749 in lieu of this. This is a short term work-around/hack of falling back to periodic compactions when ttl is set. Pull Request resolved: #6071 Test Plan: Added a unit test. Differential Revision: D18668336 Pulled By: sagar0 fbshipit-source-id: e75f5b81ba949f77ef9eff05e44bb1c757f58612
wolfkdy
pushed a commit
to wolfkdy/rocksdb
that referenced
this pull request
Dec 22, 2019
Summary: `options.ttl` is now supported in universal compaction, similar to how periodic compactions are implemented in PR facebook#5970 . Setting `options.ttl` will simply set `options.periodic_compaction_seconds` to execute the periodic compactions code path. Discarded PR facebook#4749 in lieu of this. This is a short term work-around/hack of falling back to periodic compactions when ttl is set. Pull Request resolved: facebook#6071 Test Plan: Added a unit test. Differential Revision: D18668336 Pulled By: sagar0 fbshipit-source-id: e75f5b81ba949f77ef9eff05e44bb1c757f58612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the ttl option to work with Universal compaction as well. This is an extension of the Level compaction+TTL work done in #3591. This would allow to reduce space and read amplification at the cost of more write amplification.
All compaction styles (fifo, level and universal) now work with a ttl option.
Implementation Details:
Still Todo:
PickSomeTriggeredCompactionFor later: Deprecate CompactionOptionsFIFO.ttl and instead make use of ColumnFamilyOptions.ttl for FIFO