Remove time out testing cases in error_handler_fs_test #7141
Conversation
zhichao-cao
force-pushed
the
debug_test
branch
2 times, most recently
from
cf037c4 to
ff05b94
Compare
zhichao-cao
force-pushed
the
debug_test
branch
10 times, most recently
from
7164efa to
32e9287
Compare
zhichao-cao
force-pushed
the
debug_test
branch
3 times, most recently
from
ff30828 to
a6793d2
Compare
zhichao-cao
changed the title
There was a problem hiding this comment.
@zhichao-cao has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Can the tests be marked as DISABLED_ and left in the codebase? https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#temporarily-disabling-tests
It might be a better idea. I will do as suggested. |
This reverts commit 42bf9ea.
|
@zhichao-cao has updated the pull request. You must reimport the pull request before landing. |
|
@zhichao-cao has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@zhichao-cao has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@zhichao-cao merged this pull request in ed4712f. |
Remove the 3 testing cases that cause the time out in linux build by #6765 . Will fix them later.
Test plan: make asan_check, buck run