get mononoke green in github CI #974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ahornby has updated the pull request. You must reimport the pull request before landing. |
|
@ahornby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ahornby has updated the pull request. You must reimport the pull request before landing. |
|
@ahornby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening Test Plan: **Local run of unittest** ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. mononoke ./build/fbcode_builder/getdeps.py --allow-system-packages test--src-dir=. mononoke ``` **Local run of integration test** ``` # first build sapling cli & install system deps ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. sapling ./build/fbcode_builder/getdeps.py install-system-deps --recursive mononoke_integration # then test mononoke ./build/fbcode_builder/getdeps.py --allow-system-packages build --no-deps --src-dir=. mononoke_integration ./build/fbcode_builder/getdeps.py --allow-system-packages test --src-dir=. mononoke_integration --num-jobs=4 ``` Before, fails ``` AssertionError: The test groups contain not existing tests: ['cross_repo/test-cross-repo-mononoke-git-sot-switch.t'] in /home/runner/work/sapling/sapling/eden/mononoke/tests/integration ``` After, lets see the CI Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby
|
@ahornby has updated the pull request. You must reimport the pull request before landing. |
|
This pull request was exported from Phabricator. Differential Revision: D64827811 |
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebookexperimental/moxygen
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 24, 2024
Summary: X-link: facebookincubator/zstrong#1018 * test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list * exclude flaky integration tests changes done to make this easier: * python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version * add a bit more info to the "unknown python exception" message from hg * reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening X-link: facebook/sapling#974 Reviewed By: quark-zju Differential Revision: D64827811 Pulled By: ahornby fbshipit-source-id: 82b4fa224d8ce957ef85e5ecf1e220f71c93e6c4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changes done to make this easier:
Test Plan:
Local run of unittest
Before fails:
After, passes.
Local run of integration test
Before, fails
After, passes