-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add option to process arbitrary named exports #117
Conversation
compressed-size: runtime library Size change: 0.00 kB View unchanged
|
compressed-size: e2e bundles Size change: 0.00 kB View unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
please could we cut a release containing this patch? or is there other stuff we're waiting to include? |
The Babel plugin bundle occasionally adds a special character. I'm trying to fix that so I can cut a release. |
What changed / motivation ?
By default you import stylex from the
@stylexjs/stylex
package and the compiler detects and compiles that. It has also been possible to set up custom import paths for custom aliases. However, so far it was expected that you'd still useimport * as <name>
from a custom source.This PR adds the ability to mark
stylex
to be a named export from a custom path. This lets enables the following pattern:This will enable larger UI frameworks to incorporate StyleX within their own API.
Additional Context
Added a couple of tests which are passes as expected.
Pre-flight checklist
Contribution Guidelines