-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: the animated logo in the docs index page #120
Conversation
Hi @MaxtuneLee! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
This causes horizontal scroll on small screen sizes. The way to fix this is to add |
Looks much better, but while we're at it, can we add some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
What changed / motivation ?
The animated logo in the website index page may be not display properly now? Since a part of the circle is hidden when it runs to the top of the logo.
So I changed the overflow property to visible so that the circle can be fully displayed.
Linked PR/Issues
Fixes # (issue)
Additional Context
before
after
Screenshots, Tests, Anything Else
Pre-flight checklist
Contribution Guidelines