Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: the animated logo in the docs index page #120

Merged
merged 5 commits into from
Dec 13, 2023

Conversation

MaxtuneLee
Copy link
Contributor

What changed / motivation ?

The animated logo in the website index page may be not display properly now? Since a part of the circle is hidden when it runs to the top of the logo.
So I changed the overflow property to visible so that the circle can be fully displayed.

Linked PR/Issues

Fixes # (issue)

Additional Context

before
image
after
image

Screenshots, Tests, Anything Else

Pre-flight checklist

@facebook-github-bot
Copy link

Hi @MaxtuneLee!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 10, 2023
@nmn
Copy link
Contributor

nmn commented Dec 10, 2023

This causes horizontal scroll on small screen sizes. The way to fix this is to add paddingBlock and reduce the marginBlock (use negative margin if needed)

@MaxtuneLee
Copy link
Contributor Author

MaxtuneLee commented Dec 11, 2023

This causes horizontal scroll on small screen sizes. The way to fix this is to add paddingBlock and reduce the marginBlock (use negative margin if needed)

Thanks for the tips, I tried to add paddingBlockStart and marginBlockStart, and now it works fine on small screens.
image

@nmn
Copy link
Contributor

nmn commented Dec 11, 2023

Looks much better, but while we're at it, can we add some paddingBlockEnd and reduce the marginBottom by the same amount?

@MaxtuneLee
Copy link
Contributor Author

MaxtuneLee commented Dec 13, 2023

Looks much better, but while we're at it, can we add some paddingBlockEnd and reduce the marginBottom by the same amount?

image

Get it, I added 5px paddingBlockEnd, and now the circle can be fully display in the early position too.

Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@nmn nmn merged commit f968076 into facebook:main Dec 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants