Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to @stylex/nextjs-plugin package #326

Closed
wants to merge 3 commits into from
Closed

Add types to @stylex/nextjs-plugin package #326

wants to merge 3 commits into from

Conversation

lukewhitehouse
Copy link

@lukewhitehouse lukewhitehouse commented Jan 9, 2024 •
edited
Loading

What changed / motivation ?

Adds Flow and TS types to the NextJS plugin.

Linked PR/Issues

Fixes #325

Additional Context

Screenshots, Tests, Anything Else

Pre-flight checklist

@facebook-github-bot
Copy link

Hi @lukewhitehouse!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2024
nmn
nmn reviewed Jan 9, 2024
View reviewed changes
.flowconfig
@@ -29,6 +29,8 @@ module.name_mapper='^@stylexjs/stylex$' -> '<PROJECT_ROOT>/packages/stylex/src/s
module.name_mapper='^@stylexjs/stylex\/lib\/\([a-zA-Z0-9_\-]+\)$' -> '<PROJECT_ROOT>/packages/stylex/src/\1'
module.name_mapper='^@stylexjs/babel-plugin$' -> '<PROJECT_ROOT>/packages/babel-plugin/src/index.js'
module.name_mapper='^@stylexjs/babel-plugin\/lib\/\([a-zA-Z0-9_\-]+\)$' -> '<PROJECT_ROOT>/packages/babel-plugin/src/\1'
module.name_mapper='^@stylexjs/nextjs-plugin$' -> '<PROJECT_ROOT>/packages/nextjs-plugin/src/index.js'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be needed. Nothing else is importing the nextjs plugin directly.

@nmn
Copy link
Contributor

nmn commented Jan 9, 2024

I would suggest not doing this as we will be rewriting the entire nextjs plugin soon.

It will most likely become a babel plugin + a postCSS/lightningCSS plugin instead.

@lukewhitehouse lukewhitehouse deleted the typed-nextjs branch January 9, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmn nmn nmn left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add types to @stylex/nextjs-plugin package
3 participants
@lukewhitehouse @facebook-github-bot @nmn