Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Try to add types to the Rollup Plugin #60

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Feat: Try to add types to the Rollup Plugin #60

merged 4 commits into from
Dec 12, 2023

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Dec 6, 2023 •
edited
Loading

Adds Flow and TS types to the Rollup plugin.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2023
@nmn nmn mentioned this pull request Dec 6, 2023
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

compressed-size: runtime library

Size change: 0.00 kB
Total size: 2.36 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.02 (3.53) 0.00 (0.00) 0.0% (0.0%)
./packages/stylex/lib/StyleXSheet.js 1.34 (3.41) 0.00 (0.00) 0.0% (0.0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

compressed-size: e2e bundles

Size change: 0.00 kB
Total size: 1122.94 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 998.63 (9939.85) 0.00 (0.00) 0.0% (0.0%)
./apps/rollup-example/.build/stylex.css 124.30 (874.43) 0.00 (0.00) 0.0% (0.0%)

@nmn nmn marked this pull request as draft December 6, 2023 12:09
@nmn nmn marked this pull request as ready for review December 11, 2023 19:58
@nmn nmn merged commit 1951863 into main Dec 12, 2023
9 checks passed
@nmn nmn deleted the typed-rollup branch December 12, 2023 08:41
@lukewhitehouse lukewhitehouse mentioned this pull request Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necolas necolas Awaiting requested review from necolas

@nadiia nadiia Awaiting requested review from nadiia

@nestorvanz nestorvanz Awaiting requested review from nestorvanz

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmn @facebook-github-bot