Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert esm-resolve paths to absolute paths #763

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix: convert esm-resolve paths to absolute paths #763

merged 1 commit into from
Nov 1, 2024

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Nov 1, 2024

Small fix to make esmResolve work reliably when resolving themes across packages in a mono-repo.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/scripts@0.9.0 size:compare
./size-compare.js /tmp/tmp.rwsbHRFSxJ /tmp/tmp.j0sTEZyPDG

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 729 729 1.00
· minified 2,541 2,541 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 563,025 563,025 1.00
· minified 10,185,368 10,185,368 1.00
rollup-example/.build/stylex.css
· compressed 99,154 99,154 1.00
· minified 745,649 745,649 1.00

@nmn nmn merged commit b9270ac into main Nov 1, 2024
8 checks passed
@nmn nmn deleted the fix/esm-resolve branch November 1, 2024 11:41
Samantha-Zhan pushed a commit that referenced this pull request Nov 6, 2024
@nmn @Samantha-Zhan
fix: convert esm-resolve paths to absolute paths (#763)
16ea64f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmn @facebook-github-bot