chore: extract eslint get souce code to util #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
2 tasks
mellyeliu
approved these changes
Nov 12, 2024
necolas
approved these changes
Nov 12, 2024
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| 'use strict'; | |||
|
|
|||
| import getSourceCode from './utils/getSourceCode'; | |||
There was a problem hiding this comment.
nit: we typically import modules after importing types. see the other util imports below
nmn
approved these changes
Nov 12, 2024
aminaopio
pushed a commit
to aminaopio/stylex
that referenced
this pull request
Dec 22, 2024
* chore: extract eslint get souce code to util * extract null checks * change import order for better style
aminaopio
pushed a commit
to aminaopio/stylex
that referenced
this pull request
Dec 22, 2024
* chore: extract eslint get souce code to util * extract null checks * change import order for better style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
As per reviewer comment left by @mellyeliu on PR
feat: add no-unused eslint rule to find unused styles, multiple eslint rule definition files are using identical conditional logic to get source code from Rule context such that we are backwards comparable with older eslint versions. This PR extract this logic into a separate util function so that it can be reused.Linked PR/Issues
Fixes #767
Additional Context
npx jest *running all test files insideestlint-pluginfolder, all tests still passingPre-flight checklist
Contribution Guidelines