Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #42 and #43 we don't really need a custom implementation for Serde anymore.
Advantages:
where
bounds for consumers using Serde instead of ourde/serialize
functions.de/serialize
function, which does manual de/serialization.Disadvantages:
serde
crate feature for thecurve25519-dalek
orp256
dependency. Not that big of a deal considering we aren't re-exporting them anyway, consumers will have to pull in these crates manually anyway.