Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test P-384 #84

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Test P-384 #84

merged 1 commit into from
Feb 8, 2023

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Dec 7, 2022

This just tests P-384 support and builds on top of RustCrypto/elliptic-curves#600.
We still have to wait for new versions to be released.

Builds on top of #101.
Fixes #81.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 7, 2022
@daxpedda daxpedda force-pushed the p384 branch 2 times, most recently from 8c413b6 to 0dbeefb Compare December 9, 2022 11:27
@daxpedda
Copy link
Contributor Author

daxpedda commented Dec 9, 2022

Rebased on #85.

@daxpedda
Copy link
Contributor Author

Rebased after #85.

@daxpedda
Copy link
Contributor Author

daxpedda commented Feb 1, 2023

RustCrypto/elliptic-curves#600 was just merged.
This now build on top of #101.

This would be ready to merge as soon as #101 is merged, which relies on a new release of elliptic-curve and RustCrypto/traits#1238.

@daxpedda daxpedda force-pushed the p384 branch 2 times, most recently from 8685da5 to 85acc8c Compare February 3, 2023 12:53
@daxpedda
Copy link
Contributor Author

daxpedda commented Feb 3, 2023

Everything upstream was merged now, so we are only waiting for #101.

@daxpedda daxpedda marked this pull request as ready for review February 8, 2023 08:24
@daxpedda
Copy link
Contributor Author

daxpedda commented Feb 8, 2023

This is good to go now too!

@daxpedda daxpedda mentioned this pull request Feb 8, 2023
Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see that everything works seamlessly.

@kevinlewi kevinlewi merged commit 83eb78b into facebook:main Feb 8, 2023
@daxpedda daxpedda mentioned this pull request Nov 10, 2023
2 tasks
cyyynthia pushed a commit to cyyynthia/voprf that referenced this pull request Sep 22, 2024
(cherry picked from commit 83eb78b)
kevinlewi added a commit that referenced this pull request Sep 24, 2024
* Fix Clippy (#85)

* Update `curve25519-dalek` to 4.0.0-pre.5 (#86)

* Update `curve25519-dalek`

* Improve documentation

* Adding all-features CI test (#87)

* Upgrade `p256` to v0.12 (#90)

* Upgrade `p256` to v0.12

* Upgrade MSRV to 1.60

(cherry picked from commit daa8dc0)

* Replace `json` with `serde_json` (#92)

(cherry picked from commit c8de516)

* Fix Clippy (#96)

(cherry picked from commit 74eaebe)

* Depend on `ProjectivePoint: ToEncodedPoint` (#95)

(cherry picked from commit 0409db6)

* Update `curve25519-dalek` (#94)

(cherry picked from commit 2787151)

* Use explicit crate features (#100)

(cherry picked from commit 5bce3e3)

* Bump `curve25519-dalek` to v4.0.0-rc.1 (#102)

(cherry picked from commit 8363d26)

* Test P-384 (#84)

(cherry picked from commit 83eb78b)

* Update RustCrypto dependencies to v0.13 (#106)

(cherry picked from commit 8b895cc)

* Update curve25519-dalek requirement from =4.0.0-rc.1 to =4.0.0-rc.2 (#108)

Updates the requirements on [curve25519-dalek](https://github.com/dalek-cryptography/curve25519-dalek) to permit the latest version.
- [Release notes](https://github.com/dalek-cryptography/curve25519-dalek/releases)
- [Changelog](https://github.com/dalek-cryptography/curve25519-dalek/blob/main/CHANGELOG.md)
- [Commits](dalek-cryptography/curve25519-dalek@4.0.0-rc.1...4.0.0-rc.2)

---
updated-dependencies:
- dependency-name: curve25519-dalek
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 4bd2cf4)

* Updating dual-license language (#110)

(cherry picked from commit f79ebf9)

* Bump `curve25519-dalek` to v4.0.0-rc.3 (#113)

(cherry picked from commit 209b957)

* Bump `curve25519-dalek` to v4 (#116)

(cherry picked from commit 0fdfdfd)

* Fixing clippy IntoIterator warnings (#123)

(cherry picked from commit c0162ec)

* Bump actions/checkout from 3 to 4 (#120)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 8da5684)

* Updating setup-rust-action (#125)

(cherry picked from commit 59e3fed)

* Test P-521 (#127)

(cherry picked from commit 68cc7d3)

* Fix ambiguous lifetime elision (#131)

(cherry picked from commit 40769f7)

* Bump actions/cache from 3 to 4 (#132)

Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit c93884a)

* Fixups + cherry-picking changes from #101

* Fix Clippy warnings

* More fixups, tests passing

* Ensure CI runs on branch v0.4

---------

Co-authored-by: daxpedda <daxpedda@gmail.com>
Co-authored-by: Kevin Lewi <klewi@fb.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P384 support
3 participants