Skip to content

Commit

Permalink
remove socket activation from launchd.plist
Browse files Browse the repository at this point in the history
Summary:
This will help prevent a situation like
#358 from having a similar impact in
the future.

Launchd will still launch watchman at startup and keep it running if it falls
over, but should get out of the way when we upgrade in the future.

I'll look at adding some explicit unloading of the plist at installation time
in the homebrew recipe.

Reviewed By: sid0

Differential Revision: D4417672

fbshipit-source-id: b4d4597107f26f2e4e51ecd540dfb36586cfa44c
  • Loading branch information
wez authored and facebook-github-bot committed Jan 23, 2017
1 parent 60727f9 commit 83dab35
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -449,21 +449,6 @@ static void spawn_via_launchd(void)
pid_file,
"</string>\n"
" </array>\n"
" <key>Sockets</key>\n"
" <dict>\n"
" <key>sock</key>\n" // coupled with
// get_listener_socket_from_launchd
" <dict>\n"
" <key>SockPathName</key>\n"
" <string>",
sock_name,
"</string>\n"
" <key>SockPathMode</key>\n"
" <integer>",
0600,
"</integer>\n"
" </dict>\n"
" </dict>\n"
" <key>KeepAlive</key>\n"
" <dict>\n"
" <key>Crashed</key>\n"
Expand Down

0 comments on commit 83dab35

Please sign in to comment.