Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation #321

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Add instrumentation #321

merged 4 commits into from
Sep 18, 2024

Conversation

Al-Kindi-0
Copy link
Contributor

No description provided.

Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! Should we also add instrumentation to method like evaluate_main_transition(), evaluate_aux_transistion(), evaluate_lagranage_transition() (e.g., here).

prover/src/logup_gkr/mod.rs Outdated Show resolved Hide resolved
@Al-Kindi-0
Copy link
Contributor Author

Looks good! Thank you! Should we also add instrumentation to method like evaluate_main_transition(), evaluate_aux_transistion(), evaluate_lagranage_transition() (e.g., here).

That would log the function each time it is called, which is not what we want. Probably there is a better way to get the overall time instead.

Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Than you!

@irakliyk irakliyk merged commit 8f08bd0 into facebook:logup-gkr Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants