Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels and image views baseline alignment support #132

Closed
zackhsuan opened this issue Sep 25, 2015 · 9 comments
Closed

Labels and image views baseline alignment support #132

zackhsuan opened this issue Sep 25, 2015 · 9 comments

Comments

@zackhsuan
Copy link

Hi all,

Flexbox natively supports baseline alignment, but it seems like react-native has not implemented this yet.
I suppose that it would be awesome if css-layout could offer controls like labels or image views to work with baseline mode. Plus, the native auto layout tech supports baseline alignment too.

Many thanks. I appreciate all you excellent work.
@zackhsuan
Copy link
Author

Is anyone here could help?

@lucasr
Copy link
Contributor

lucasr commented Oct 9, 2015

I thinks this ticket is more about React Native than css-layout itself as this requires some platform-specific bits. Unless I'm missing something?

@zackhsuan
Copy link
Author

Thanks for your reply. @lucasr but unfortunately, I was redirected by React Native to post the issue here. facebook/react-native#3020 Any idea that I can at least get the right place to post this issue?

@emilsjolander
Copy link
Contributor

Baseline support is definitely something which would be great if we could support. We are not actively working on this but I would be happy to work with you or anyone else in the community on a pull request implementing it.

@mpost
Copy link

mpost commented Dec 30, 2016

baseline support sounds like a must have. Currently it is not possible to accurately align a "label" and a "text input" to be optical in line across platforms.

@emilsjolander
Copy link
Contributor

@mpost totally agreed. Just not a top priority yet.

@mpost
Copy link

mpost commented Dec 31, 2016

@emilsjolander thanks for the info. Speaking of top priorities, is there a roadmap to features we could expect?

@emilsjolander
Copy link
Contributor

No roadmap just yet. I am thinking about posting something soon.

@woehrl01 woehrl01 mentioned this issue Jan 4, 2017
Closed
facebook-github-bot pushed a commit that referenced this issue Jan 6, 2017
@woehrl01 @facebook-github-bot
Baseline support
c169a98 
Summary:
Added baseline support (see #132)

You have the ability for a custom baseline function (```float(*YGBaselineFunc)(YGNodeRef node);```) to return whatever baseline you want.
Closes #317

Reviewed By: splhack

Differential Revision: D4385061

Pulled By: emilsjolander

fbshipit-source-id: cb8a59a09237c840fa3e21753ab68239997dab0c
@woehrl01
Copy link
Contributor

woehrl01 commented Jan 6, 2017

@emilsjolander @zackhsuan this can be closed now, can't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mpost @lucasr @emilsjolander @woehrl01 @zackhsuan