Fix bug with align start not taking into account parent padding #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51374086 |
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
|
This pull request was exported from Phabricator. Differential Revision: D51374086 |
joevilches
force-pushed
the
export-D51374086
branch
from
f394da9 to
a355ce6
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 4, 2023
…book#1484) Summary: Pull Request resolved: facebook#1484 X-link: facebook/react-native#41687 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086 fbshipit-source-id: 3c8b83b16886b60e843b7aa867a57da2624ba842
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
force-pushed
the
export-D51374086
branch
from
a355ce6 to
bf3788f
Compare
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
…book#1484) Summary: X-link: facebook/react-native#41687 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
|
This pull request was exported from Phabricator. Differential Revision: D51374086 |
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 6, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
force-pushed
the
export-D51374086
branch
from
bf3788f to
7d1c258
Compare
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 6, 2023
…book#1484) Summary: X-link: facebook/react-native#41687 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 6, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 6, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
|
This pull request was exported from Phabricator. Differential Revision: D51374086 |
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 6, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
force-pushed
the
export-D51374086
branch
from
9001efa to
55be53d
Compare
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
…book#1484) Summary: X-link: facebook/react-native#41687 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
|
This pull request was exported from Phabricator. Differential Revision: D51374086 |
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
…ng absolute node's position (facebook#1481) Summary: X-link: facebook/react-native#41684 Absolute nodes can be laid out by themselves and do not have to care about what is happening to their siblings. Because of this we can make `positionAbsoluteChild` the sole place where we handle this logic. Right now that is scattered around algorithm with many `if (child is absolute)` cases everywhere. This makes implementing position static a lot harder since we are relying on the CB to do all this work, not the parent. With this change the only time we set position for an absolute node and it matter (i.e. not overwritten) is in `positionAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51290723
Summary: X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
…ox (facebook#1485) Summary: X-link: facebook/react-native#41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526
Summary: This test is for ensuring caching does not break layout when a CB changes. No changes were needed to get this passing it just works this way with the implementation we chose earlier. Reviewed By: NickGerleman Differential Revision: D51333812
…book#1484) Summary: X-link: facebook/react-native#41687 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
force-pushed
the
export-D51374086
branch
from
55be53d to
215d8ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51374086 |
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
…book#41687) Summary: X-link: facebook/yoga#1484 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Dec 8, 2023
Summary: X-link: facebook/yoga#1484 X-link: facebook/react-native#41687 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086 fbshipit-source-id: ed9d79887aa1613ea93c10c639cd1465271d23d8
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Dec 8, 2023
Summary: X-link: facebook/yoga#1484 Pull Request resolved: #41687 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086 fbshipit-source-id: ed9d79887aa1613ea93c10c639cd1465271d23d8
|
This pull request has been merged in d1dda21. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…book#41687) Summary: X-link: facebook/yoga#1484 Pull Request resolved: facebook#41687 Tsia. Added test and accounted for parent padding Reviewed By: NickGerleman Differential Revision: D51374086 fbshipit-source-id: ed9d79887aa1613ea93c10c639cd1465271d23d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#41687
Tsia. Added test and accounted for parent padding
Reviewed By: NickGerleman
Differential Revision: D51374086