Extra log for case where availableHeight is undefined and sizing mode != max content #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D61054392 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Aug 12, 2024
… != max content (facebook#1687) Summary: X-link: facebook/react-native#45965 Pull Request resolved: facebook#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Differential Revision: D61054392
|
This pull request was exported from Phabricator. Differential Revision: D61054392 |
joevilches
force-pushed
the
export-D61054392
branch
from
4701fa1 to
29d38af
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Aug 12, 2024
… != max content (facebook#45965) Summary: Pull Request resolved: facebook#45965 X-link: facebook/yoga#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Differential Revision: D61054392
|
This pull request was exported from Phabricator. Differential Revision: D61054392 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Aug 16, 2024
… != max content (facebook#1687) Summary: X-link: facebook/react-native#45965 Pull Request resolved: facebook#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61054392
joevilches
force-pushed
the
export-D61054392
branch
from
29d38af to
8e4dfb9
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Aug 16, 2024
… != max content (facebook#45965) Summary: Pull Request resolved: facebook#45965 X-link: facebook/yoga#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61054392
… != max content (facebook#1687) Summary: X-link: facebook/react-native#45965 Pull Request resolved: facebook#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61054392
|
This pull request was exported from Phabricator. Differential Revision: D61054392 |
joevilches
force-pushed
the
export-D61054392
branch
from
8e4dfb9 to
0b19270
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Aug 19, 2024
… != max content (facebook#45965) Summary: Pull Request resolved: facebook#45965 X-link: facebook/yoga#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61054392
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Aug 19, 2024
… != max content Summary: X-link: facebook/react-native#45965 X-link: facebook/yoga#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61054392 fbshipit-source-id: 654ff96f94aa89605a603e2e36335bb48b61f4a2
|
This pull request has been merged in 596f8df. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 19, 2024
… != max content (#45965) Summary: Pull Request resolved: #45965 X-link: facebook/yoga#1687 We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61054392 fbshipit-source-id: 654ff96f94aa89605a603e2e36335bb48b61f4a2
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Nov 13, 2024
…ing mode != max content (microsoft#1687)" Summary: Reverting facebook/yoga#1687 as it appears to regress Yoga performance anywhere from 10-33%. ## Changelog [Internal] Differential Revision: D65863569
rozele
added a commit
to rozele/yoga
that referenced
this pull request
Nov 13, 2024
…ing mode != max content (facebook#1687)" Summary: Reverting facebook#1687 as it appears to regress Yoga performance anywhere from 10-33%. ## Changelog [Internal] Differential Revision: D65863569
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 13, 2024
…ing mode != max content (#1687)" Summary: X-link: facebook/yoga#1741 X-link: facebook/react-native#47581 Reverting facebook/yoga#1687 as it appears to regress Yoga performance anywhere from 10-33%. ## Changelog [Internal] Reviewed By: rshest Differential Revision: D65863569 fbshipit-source-id: e6992e05dd59ba75548a5d633cb7f5c3fa99a6e4
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 13, 2024
…ing mode != max content (#1687)" (#47581) Summary: X-link: facebook/yoga#1741 Pull Request resolved: #47581 Reverting facebook/yoga#1687 as it appears to regress Yoga performance anywhere from 10-33%. ## Changelog [Internal] Reviewed By: rshest Differential Revision: D65863569 fbshipit-source-id: e6992e05dd59ba75548a5d633cb7f5c3fa99a6e4
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
…ing mode != max content (#1687)" (#1741) Summary: Pull Request resolved: #1741 X-link: facebook/react-native#47581 Reverting #1687 as it appears to regress Yoga performance anywhere from 10-33%. ## Changelog [Internal] Reviewed By: rshest Differential Revision: D65863569 fbshipit-source-id: e6992e05dd59ba75548a5d633cb7f5c3fa99a6e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We are seeing some crashes that are hard to wrap our head around. Lets add more logs. I chose these values based on what could make the height/width undefined from looking at the code. We might need more but this should give us some more direction.
Changelog: [Internal]
Differential Revision: D61054392