Feature hidden nodes #302
Feature hidden nodes #302
Conversation
When iterating over the nodes we check if the node is hidden. When it's hidden we do skip it and go to the next child in line.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
@roxlu Are you planning to update this? |
|
@emilsjolander Yes, I'll fix that this weekend. Sorry for not replying earlier. |
|
Np! Just checking in :) no rush
…On Thu, 5 Jan 2017 at 20:28, @roxlu ***@***.***> wrote:
@emilsjolander <https://github.com/emilsjolander> Yes, I'll fix that this
weekend. Sorry for not replying earlier.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#302 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABdIpDUEjx2fzKhL5dALuGITHuIUuekYks5rPVJ9gaJpZM4LVGNi>
.
|
|
Hey @roxlu This is a feature we'd definitely need. However, having it as a property is is must for us. Tests are also required. |
|
Will look at this then! |
|
Hey @joce and @emilsjolander I've been ill last week and am catching up on work so I won't have any spare time for this until the end of February. @joce my branch with the hide/show feature is here: https://github.com/roxlu/css-layout/tree/feature-hidden-nodes if you want to have a look. |
|
A major issue I have however is that I'm on Windows, compiling with VisualStudio, and therefore I do not have a C99 compiler. I would need to have this feature based on a branch that compiles in C++98. Is this workable for you? |
|
@joce I had the same problem. compiling on windows works with vs15 community edition. |
|
@woehrl01 Excellent! I'll give that a try tonight, then. |
|
@joce any update? |
|
Taken with other fires at work atm.
…On Mon, Jan 30, 2017 at 12:21 PM, Emil Sjölander ***@***.***> wrote:
@joce <https://github.com/joce> any update?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#302 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAE56QZtOWxY9q6fPDP_CLf1mx5WOQByks5rXhwcgaJpZM4LVGNi>
.
|
|
@joce @emilsjolander I help out with a new PR #369 with the suggested changes. So you can focus on the fires @joce 🔥 🏃 😄 |
Summary: Fix #241 and successor for #302 Added new property ```display``` with ```YGDisplayFlex``` and ```YGDisplayNone```. Allows to hide nodes from the layout without the need to remove it from the DOM. Closes #369 Reviewed By: astreet Differential Revision: D4501141 Pulled By: emilsjolander fbshipit-source-id: 0dfeee381f6d1e4bbba81926126b83dd7abab9d6
No description provided.