Fix shrinking in non strech alignments while retaining legacy behaviour #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woehrl01
force-pushed
the
flex_start_shrink
branch
from
d32ff55
to
7d8fe09
Compare
keep legacyStretchBehaviour
woehrl01
force-pushed
the
flex_start_shrink
branch
from
7d8fe09
to
541aeb6
Compare
|
Thanks! |
There was a problem hiding this comment.
@emilsjolander is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 27, 2017
Summary: This fixes shrinking of elements which are in a non stretch alignment, but keeps the legacy stretch behaviour in place. Additionally this adds a testcase for ```useLegacyStretchBehaviour``` Fixes #633 Closes facebook/yoga#635 Differential Revision: D6408037 Pulled By: emilsjolander fbshipit-source-id: 377ab0308dd3a75a148a0af31ab5eb3ffb5b5d83
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 27, 2017
Summary: This fixes shrinking of elements which are in a non stretch alignment, but keeps the legacy stretch behaviour in place. Additionally this adds a testcase for ```useLegacyStretchBehaviour``` Fixes #633 Closes facebook/yoga#635 Differential Revision: D6408037 Pulled By: emilsjolander fbshipit-source-id: 377ab0308dd3a75a148a0af31ab5eb3ffb5b5d83
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: This fixes shrinking of elements which are in a non stretch alignment, but keeps the legacy stretch behaviour in place. Additionally this adds a testcase for ```useLegacyStretchBehaviour``` Fixes facebook#633 Closes facebook/yoga#635 Differential Revision: D6408037 Pulled By: emilsjolander fbshipit-source-id: 377ab0308dd3a75a148a0af31ab5eb3ffb5b5d83
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: This fixes shrinking of elements which are in a non stretch alignment, but keeps the legacy stretch behaviour in place. Additionally this adds a testcase for ```useLegacyStretchBehaviour``` Fixes facebook#633 Closes facebook/yoga#635 Differential Revision: D6408037 Pulled By: emilsjolander fbshipit-source-id: 377ab0308dd3a75a148a0af31ab5eb3ffb5b5d83
vincentriemer
pushed a commit
to vincentriemer/yoga-dom
that referenced
this pull request
May 9, 2018
Summary: This fixes shrinking of elements which are in a non stretch alignment, but keeps the legacy stretch behaviour in place. Additionally this adds a testcase for ```useLegacyStretchBehaviour``` Fixes #633 Closes facebook/yoga#635 Differential Revision: D6408037 Pulled By: emilsjolander fbshipit-source-id: 377ab0308dd3a75a148a0af31ab5eb3ffb5b5d83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes shrinking of elements which are in a non stretch alignment, but keeps the legacy stretch behaviour in place. Additionally this adds a testcase for
useLegacyStretchBehaviourFixes #633