Expose dirtied func in Javascript bindings #842
Conversation
|
Hello @davidaurelio I see that you've been actively working on some things in this project, do you think you could have a look at this? CI is failing, but that's unrelated (fixed in #843). Let me know if it's not okay to tag you like this and if there is a better way to get some eyes on these PRs 😄 |
|
ok, let’s merge it. Which way did you test this? |
There was a problem hiding this comment.
@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I ported the |
There was a problem hiding this comment.
@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Noticed that the |
There was a problem hiding this comment.
@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Yoga currently has the concept of a 'dirtied func', which is called when a Node becomes dirty, which can be useful to trigger a repaint. This PR exposes that functionality in the Javascript bindings.