Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing parens in macro definition #3301

Closed
terrelln opened this issue Oct 27, 2022 · 2 comments · Fixed by #3365
Closed

Missing parens in macro definition #3301

terrelln opened this issue Oct 27, 2022 · 2 comments · Fixed by #3365
Assignees
@terrelln
Labels
enhancement good first issue help wanted static-analysis

Comments

@terrelln
Copy link
Contributor

terrelln commented Oct 27, 2022 •
edited
Loading

RANK_POSITION_LOG_BUCKETS_BEGIN and RANK_POSITION_DISTINCT_COUNT_CUTOFF need parens around their definitions.

Their uses are still correct without parens, but this is a code smell.

https://lore.kernel.org/oe-kbuild/20221027075910._PbWJp-5TkY_Ws8XnTmi6N1OnHCeRmO-lRyZj3XRJBk@z/T/#mbfb497176c369eb99f264c8c66cbef8883d29c57

Reported-by: kernel test robot lkp@intel.com
Reported-by: Dan Carpenter dan.carpenter@oracle.com
@embg embg assigned embg and terrelln and unassigned embg Oct 31, 2022
@fool1280
Copy link

fool1280 commented Nov 5, 2022

Hi, can I take on this issue? It seems like a simple fix for a first time contributor like me. Thank you!

@terrelln
Copy link
Contributor Author

terrelln commented Nov 7, 2022

Absolutely!

terrelln added a commit to terrelln/zstd that referenced this issue Dec 16, 2022
@terrelln
Add missing parens around macro definition
4927665 
Fixes facebook#3301.
@terrelln terrelln mentioned this issue Dec 16, 2022
Merged
terrelln added a commit that referenced this issue Dec 16, 2022
@terrelln
Add missing parens around macro definition
ee6475c 
Fixes #3301.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrelln terrelln

Labels
enhancement good first issue help wanted static-analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing parens around macro definition terrelln/zstd
3 participants
@terrelln @embg @fool1280