Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adaptive parameter updates using --adapt don't get triggered if --no-progress is used #3353

Closed
terrelln opened this issue Dec 14, 2022 · 0 comments
Closed

Adaptive parameter updates using --adapt don't get triggered if --no-progress is used #3353

terrelln opened this issue Dec 14, 2022 · 0 comments
Assignees
@terrelln
Labels
bug release-blocking Must be done by the release

Comments

@terrelln
Copy link
Contributor

This command doesn't trigger adaptive parameter updating

zstd --adapt --no-progress
@terrelln terrelln added bug release-blocking Must be done by the release labels Dec 14, 2022
@terrelln terrelln self-assigned this Dec 14, 2022
terrelln added a commit to terrelln/zstd that referenced this issue Dec 14, 2022
@terrelln
[fileio] Separate parameter adaption from display update rate
dd38093 
Split the logic for parameter adaption from the logic to update the display rate.
This decouples the two updates, so changes to display updates don't affect
parameter adaption.

Also add a test case that checks that parameter adaption actually happens.

This fixes Issue facebook#3353, where --adapt is broken when --no-progress is passed.
@terrelln terrelln mentioned this issue Dec 14, 2022
Merged
terrelln added a commit to terrelln/zstd that referenced this issue Dec 14, 2022
@terrelln
[fileio] Separate parameter adaption from display update rate
a8d6ba0 
Split the logic for parameter adaption from the logic to update the display rate.
This decouples the two updates, so changes to display updates don't affect
parameter adaption.

Also add a test case that checks that parameter adaption actually happens.

This fixes Issue facebook#3353, where --adapt is broken when --no-progress is passed.
terrelln added a commit to terrelln/zstd that referenced this issue Dec 15, 2022
@terrelln
[fileio] Separate parameter adaption from display update rate
801f964 
Split the logic for parameter adaption from the logic to update the display rate.
This decouples the two updates, so changes to display updates don't affect
parameter adaption.

Also add a test case that checks that parameter adaption actually happens.

This fixes Issue facebook#3353, where --adapt is broken when --no-progress is passed.
terrelln added a commit that referenced this issue Dec 15, 2022
@terrelln
[fileio] Separate parameter adaption from display update rate
15f32ad 
Split the logic for parameter adaption from the logic to update the display rate.
This decouples the two updates, so changes to display updates don't affect
parameter adaption.

Also add a test case that checks that parameter adaption actually happens.

This fixes Issue #3353, where --adapt is broken when --no-progress is passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrelln terrelln

Labels
bug release-blocking Must be done by the release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrelln