Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[legacy] Fix Huffman jump table reads in v01 and v05 #1594

Merged
merged 1 commit into from
Apr 19, 2019
Merged

[legacy] Fix Huffman jump table reads in v01 and v05 #1594

merged 1 commit into from
Apr 19, 2019

Conversation

terrelln
Copy link
Contributor

  • We would read the jump table before checking the source size.
  • The v05 bug was caught by the simple_decompress fuzzer now that we are running with legacy support enabled.
  • The v01 bug was caught by manual inspection.
  • All the other legacy versions seem to check the header correctly.

@terrelln terrelln merged commit 9ad7ea4 into facebook:dev Apr 19, 2019
@felixhandte felixhandte mentioned this pull request Jul 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrelln @Cyan4973 @facebook-github-bot