Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cmake lz4 support #1626

Merged
merged 2 commits into from
Jun 19, 2019
Merged

add cmake lz4 support #1626

merged 2 commits into from
Jun 19, 2019

Conversation

LeeYoung624
Copy link
Contributor

Add some instructions in build/cmake/README.md for guys not familiar with cmake. Show them how to build with options
Yes, I saw there is a cmake support, but it can be improved using a CMakeLists.txt file and have a flag for each thing we want to build or not.

Add lz4 format support for zstd program, with a new cmake module FindLibLZ4.cmake added to find lz4 library.
This has been test on:
suse12sp2 cmake 3.12.1 lz4 1.8.3
windows10 cmake 3.12.1 lz4 1.8.3
ubuntu12.04 cmake 3.0.2 lz4 1.8.3
centos7.4 cmake 2.8.12 lz4 1.8.3
redhat7.2 cmake 3.0.2 lz4 1.8.3
with tests like:
lz4 compressed file->zstd decompress file->diff files
zstd compressed file->lz4 decompress file->diff files
Issue#715

I rebased my last pull request and restart a new pull request again

add some instructions for build/cmake/README.md
@Cyan4973
Copy link
Contributor

Thanks for the patch @LeeYoung624 ,
it looks clear and is well documented !

@Cyan4973 Cyan4973 merged commit b26818f into facebook:dev Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants