-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake bug fix: didn't install zstdless and zstdgrep. #1647
Conversation
The commit itself might be improved, I suggest something like this:
|
@Mno-hime Do you mean that the commit message should be more specific? |
Yes, subject of the pull request is ok, but the commit message can be more specific about what's happening in the commit. |
Sure, I think you are right. Thank you so much @Mno-hime . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the stack! I have one last suggested change: it would be cleaner if you could use ${PROGRAMS_DIR}/
rather than ${CMAKE_SOURCE_DIR}/../../programs/
. Will that work? And if so, can you switch to that?
Thanks!
Sure. I have switched to this. |
Thanks @LeeYoung624 |
CMake bug fix: CMake didn't install zstdless and zstdgrep.
I mess up the last PR#1625 and create a new PR here.
Really sorry about this. @felixhandte