Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ZSTD_DLL_EXPORT=1 for static lib #1650

Merged
merged 1 commit into from
Jun 15, 2019
Merged

Remove ZSTD_DLL_EXPORT=1 for static lib #1650

merged 1 commit into from
Jun 15, 2019

Commits on Jun 12, 2019

  1. Remove ZSTD_DLL_EXPORT=1 for static lib 

    As a principle, static libs should not dllexport methods, that should only be used when building DLLs.

Case in point: when static libs with dllexport directives are linked into DLLs created with a .def file, the VC++ compiler exports the dllexported methods into the DLL, in addition to the exports listed in the .def file. This will result in undesired link dependencies and is not the correct thing to do.
    @scharan
    scharan committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    f547dca View commit details
    Browse the repository at this point in the history