Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Input From Console When -f/--force is Passed #2466

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Allow Input From Console When -f/--force is Passed #2466

merged 2 commits into from
Jan 18, 2021

Conversation

felixhandte
Copy link
Contributor

Addresses #2463.

@felixhandte felixhandte changed the title Allow Input From Console When --force is Passed Allow Input From Console When -f/--force is Passed Jan 11, 2021
@Cyan4973
Copy link
Contributor

Cyan4973 commented Jan 11, 2021 •
edited
Loading

minor :
it would be great if we could also have a test validating this new ability in playTests.sh.
But I'm unsure if that's possible ...

@Cyan4973 Cyan4973 merged commit 7c2a17e into facebook:dev Jan 18, 2021
@felixhandte felixhandte mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrelln terrelln terrelln approved these changes

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixhandte @Cyan4973 @terrelln @facebook-github-bot